-
Notifications
You must be signed in to change notification settings - Fork 215
Confusing message from firefox.com/pair on iOS #18061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Basically Firefox on iPad pretends to be desktop Safari — so my guess is that's what's being detected. A good countermeasure is to additionally look for coarse pointer or touch/drag events, that can tell the UA is only "pretending" to be desktop Safari, in which case a mobile device can be inferred and the same "Open Firefox on your computer" message served. |
According to comments in the code used to detect the devices, it's a known issue: fxa/packages/fxa-content-server/app/scripts/lib/user-agent.js Lines 33 to 53 in 0234048
|
The culprit might be in outdated fxa/packages/fxa-content-server/package.json Line 128 in 0234048
According to faisalman/ua-parser-js@5ea9f0e this should work as of v2.0.0 — however there are a few breaking changes regarding mobile UAs: https://github.com/faisalman/ua-parser-js/releases/tag/2.0.0-alpha.2 EDIT: v2 changed licensing so its AGPL might be incompatible here. In that case additional feature checks exist even in v1.0.x that help identify iPad by touch/drag capability: https://docs.uaparser.dev/api/main/idata/with-feature-check.html |
Nonetheless, there's a shim in mozilla-mobile/firefox-ios#23089 that should send the mobile UAstring to |
NB: This seems to have been fixed few weeks before OP reported it here, only took some time to release, should not happen on v133.1+ ☝ I was not able to reproduce the "not using Firefox" screen; testing the above mentioned user agent definition for all No matter if I set it to display in "desktop mode": or in "mobile mode": Compare to staging site, where this special treatment for the user agent is not applied: and here it would alternate between "open Firefox on your computer" and "not using Firefox" based on "request desktop" or "request mobile" site. So this seems to be fixed with mozilla-mobile/firefox-ios#22435, should not reproduce since v133.1 (backported). |
Uh oh!
There was an error while loading. Please reload this page.
Description
When signing up a new phone and linking it to an existing account, you're told to visit firefox.com/pair to link your account. If you do this on Firefox iOS on iPad you don't get the helpful message "use a computer" message.
Steps to reproduce
With Firefox on iPadOS, visit firefox.com/pair and observe the message.
Expected result
On Firefox on an iPhone you get the following message:
Actual result
On Firefox on iPadOS you get this message:
Environment
Firefox 132.1 (47104)
iPadOS 18.1.1
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: